Bump decimal to ~> 3.0#7
Merged
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the Valdi project’s decimal dependency to the 3.x series to address a security advisory and ensure downstream users pull in the fixed version. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since
decimal ~> 3.0requires Elixir~> 1.12, consider updating the project’selixirversion inmix.exsand aligning the CI Elixir version so consumers and CI don’t end up with a mismatched toolchain.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since `decimal ~> 3.0` requires Elixir `~> 1.12`, consider updating the project’s `elixir` version in `mix.exs` and aligning the CI Elixir version so consumers and CI don’t end up with a mismatched toolchain.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Author
|
@bluzky your review would be really helpful when you have the time 🙏 |
Owner
|
Thanks @js-ms, will release update now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off, thanks for valdi! It's been a really useful little library for us at Wenia.
Description
Bumps the
decimaldependency to~> 3.0.The recent CVE-2026-32686 report confirms
decimalneeds to be upgraded. Pinning to~> 3.0makes sure downstream users get that change.Note
Decimal requires Elixir
~> 1.12and valdi's CI runs on elixir 1.10.3, happy to follow up on this if we need a CI Bump, Just let me know.I think this is a breaking change for downstream users on
decimal ~> 2.0. You'll probable need a 0.7.0 release.Tests were verified locally.
Shoutout to @estebanz01 for spotting this one for me 🙏
Summary by Sourcery
Build: